Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed #246: there is no need to swap main script in package.json for development #247

Merged
merged 2 commits into from
Jul 9, 2017
Merged

fixed #246: there is no need to swap main script in package.json for development #247

merged 2 commits into from
Jul 9, 2017

Conversation

gagarin55
Copy link
Contributor

@gagarin55 gagarin55 commented Jul 8, 2017 •
edited
Loading

solution for #246 contains 2 steps:

  1. We don't have to run babel again in npm run start:electron command
  2. webpack has an issue with electron-store, webpack.electron.js has been updated in accordance with doesn't work with webpack sindresorhus/electron-store#3

@gagarin55 gagarin55 requested a review from whilei July 8, 2017 13:35
@splix
Copy link
Member

splix commented Jul 8, 2017

so @whilei owes you a beer now? :)

@elaineo
Copy link
Contributor

elaineo commented Jul 8, 2017

thank you for fixing this, i owe you a beer too

@gagarin55 gagarin55 merged commit fe46571 into emeraldpay:master Jul 9, 2017
@gagarin55 gagarin55 deleted the webpack-fix branch July 12, 2017 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@splix splix splix approved these changes

@whilei whilei Awaiting requested review from whilei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gagarin55 @splix @elaineo