tx history update #518
Merged
tx history update #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanejonas
force-pushed
the
feature/tx-history-update
branch
from
3d13de6
to
3e62ecf
Compare
solution: add ui for confirmations + fix bug with tx view updating
shanejonas
force-pushed
the
feature/tx-history-update
branch
from
3e62ecf
to
3b52ccd
Compare
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
==========================================
- Coverage 19.13% 19.11% -0.02%
==========================================
Files 159 159
Lines 3162 3180 +18
Branches 385 390 +5
==========================================
+ Hits 605 608 +3
- Misses 2306 2317 +11
- Partials 251 255 +4
Continue to review full report at Codecov.
|
gagarin55
reviewed
Mar 7, 2018
| @@ -22,9 +22,11 @@ export default connect( | |||
|
|
|||
| return { | |||
| showFiat: launcher.selectors.getChainName(state).toLowerCase() === 'mainnet', | |||
| network: state.network.toJS(), | |||
There was a problem hiding this comment.
This will cause re-rendering component because toJS() produces new object every time. Do we need whole network structure or currentBlockNumber is enough here ?
gagarin55
reviewed
Mar 7, 2018
| @@ -83,4 +105,8 @@ TxView.propTypes = { | |||
| fromAccount: PropTypes.object.isRequired, | |||
| openTx: PropTypes.func.isRequired, | |||
| refreshTx: PropTypes.func.isRequired, | |||
| currentBlock: PropTypes.string.isRequired, | |||
There was a problem hiding this comment.
Didn't find usage of currentBlock property, instead we have network property not declared here
gagarin55
reviewed
Mar 7, 2018
| // TODO: move tx status to own component | ||
| // TODO: timestamp | ||
| let txStatus = null; | ||
| if (tx.get('blockNumber')) { | ||
| txStatus = <span style={{color: 'limegreen'}} onClick={ openTx }>Success</span>; |
There was a problem hiding this comment.
Can we use this color #47B04B for success
gagarin55
approved these changes
Mar 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #486
fixes #500
fixes #518