Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error dialogs for uncaught network errors #634

Merged
merged 5 commits into from
Jun 12, 2018
Merged

Conversation

BelfordZ
Copy link
Contributor

@BelfordZ BelfordZ commented Jun 11, 2018

@whilei addresses #614
errordialog

@ghost ghost assigned BelfordZ Jun 11, 2018
@ghost ghost added the review label Jun 11, 2018
const returnVal = method(...props, dispatch, getState, api);
if (returnVal.catch) {
returnVal.catch((e) => dispatch(screen.actions.showError(e)));
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you forgot to return returnVal here

@@ -6,100 +6,99 @@ import createLogger from '../../utils/logger';
import ActionTypes from './actionTypes';
import history from '../wallet/history';

import network from './';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would cause a circular dependency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but webpack doesnt seem to care...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really hard to make this work without this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have these actions in this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but they are wrapped in the index.js

I could wrap them within this file, and call the wrapped variant instead I suppose

@codecov
Copy link

codecov bot commented Jun 12, 2018

Codecov Report

Merging #634 into master will increase coverage by <.01%.
The diff coverage is 29.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #634      +/-   ##
==========================================
+ Coverage   27.38%   27.38%   +<.01%     
==========================================
  Files         157      158       +1     
  Lines        2991     2998       +7     
  Branches      404      404              
==========================================
+ Hits          819      821       +2     
- Misses       1949     1955       +6     
+ Partials      223      222       -1
Impacted Files Coverage Δ
src/store/wallet/screen/screenActions.js 25% <ø> (+3.57%) ⬆️
src/store/launcher/launcherActions.js 2.56% <ø> (ø) ⬆️
src/components/common/ErrorDialog/errorDialog.js 0% <0%> (ø) ⬆️
src/store/wallet/screen/screenReducers.js 88.88% <0%> (ø) ⬆️
src/store/store.js 15.55% <0%> (ø) ⬆️
src/store/network/networkActions.js 34.78% <37.5%> (-1.59%) ⬇️
src/store/middleware/promise-catch-all.js 54.54% <54.54%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35cb92f...3c6c5bd. Read the comment docs.

@BelfordZ BelfordZ merged commit a15b704 into master Jun 12, 2018
@BelfordZ BelfordZ deleted the error-dialogs branch June 12, 2018 23:29
@ghost ghost removed the review label Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants