problem: SignTx dialog renders wrong tx value #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
gagarin55
force-pushed
the
fix-signtxform
branch
from
a8aa083
to
3556485
Compare
Codecov Report
@@ Coverage Diff @@
## master #639 +/- ##
==========================================
+ Coverage 27.42% 27.85% +0.43%
==========================================
Files 158 158
Lines 3001 2990 -11
Branches 405 405
==========================================
+ Hits 823 833 +10
+ Misses 1956 1936 -20
+ Partials 222 221 -1
Continue to review full report at Codecov.
|
shanejonas
reviewed
Jun 12, 2018
| const { value, fiatRate, fiatCurrency, fee, tx } = props; | ||
| const { onCancel, handleSubmit } = props; | ||
| export const SignTx = ((props) => { | ||
| const { fiatRate, fiatCurrency, fee, tx, nativeTx } = props; |
There was a problem hiding this comment.
dont need nativeTx here
BelfordZ
reviewed
Jun 12, 2018
| }; | ||
|
|
||
| describe('SignTx', () => { | ||
| it('should render tx value correctly', () => { |
|
LGTM after removing the unused var. Speaking of which -- Why did this not produce a linting error? |
BelfordZ
approved these changes
Jun 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.