Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smooth scrolling introduced latency #4401

Closed
emilk opened this issue Apr 24, 2024 · 0 comments · Fixed by #4526
Closed

Smooth scrolling introduced latency #4401

emilk opened this issue Apr 24, 2024 · 0 comments · Fixed by #4526
Labels
rerun Desired for Rerun.io
Milestone
Next Major Release

Comments

@emilk
Copy link
Owner

emilk commented Apr 24, 2024

A recent egui release introduced smoothed scrolling (InputState::smooth_scroll_delta) which is used by ScrollArea and other things.

For mice with discreet scroll steps this is a big win, making scrolling smooth and nice.

For platforms with smooth scroll input (e.g. Mac trackpads) however, it only adds latency for no win.

It would be nice if we could somehow get the best of two worlds, i.e. only apply the smoothing in case the input it sharp/discreet.
@emilk emilk added the rerun Desired for Rerun.io label Apr 24, 2024
Repository owner deleted a comment from rustbasic Apr 24, 2024
@emilk emilk added this to the Next Major Release milestone May 22, 2024
@emilk emilk mentioned this issue May 22, 2024
Merged
emilk added a commit that referenced this issue May 22, 2024
@emilk
Remove Event::Scroll and handle it in egui (#4524)
48045e5 
For integrations: just emit `egui::Event::MouseWheel` (like before).
egui will interpret that as zoom or pan.

On the way towards #4401
@emilk emilk mentioned this issue May 22, 2024
Merged
emilk added a commit that referenced this issue May 23, 2024
@emilk
Remove scroll latency for smooth trackpads (#4526)
8db8f6d 
* Closes #4401

It was small, but annoying. Now we get that butter smooth scrolling on
mac trackpads again, with no latency
hacknus pushed a commit to hacknus/egui that referenced this issue Oct 30, 2024
@emilk @hacknus
Remove Event::Scroll and handle it in egui (emilk#4524)
45447cd 
For integrations: just emit `egui::Event::MouseWheel` (like before).
egui will interpret that as zoom or pan.

On the way towards emilk#4401
hacknus pushed a commit to hacknus/egui that referenced this issue Oct 30, 2024
@emilk @hacknus
Remove scroll latency for smooth trackpads (emilk#4526)
bb729b8 
* Closes emilk#4401

It was small, but annoying. Now we get that butter smooth scrolling on
mac trackpads again, with no latency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rerun Desired for Rerun.io
Projects
None yet
Milestone
Next Major Release
Development

Successfully merging a pull request may close this issue.

Remove scroll latency for smooth trackpads emilk/egui
1 participant
@emilk