Move first request_animation_frame into resize observer
#4628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprochazk
added
web
jprochazk
changed the title
request_animation_frame to resize observerrequest_animation_frame into resize observer
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
This PR ensures the first animation frame happens _after_ the resize observer has had a chance to do its job. * Closes emilk#4622 The first commit contains some `log` calls to observe the changed behavior: Before: ``` [eframe::web::app_runner] eframe/src/web/app_runner.rs:191: LOGIC [300.0 150.0] [eframe::web::events] eframe/src/web/events.rs:633: ResizeObserver canvas=[300.0 150.0] to=(1920, 993) [eframe::web::app_runner] eframe/src/web/app_runner.rs:191: LOGIC [1920.0 993.0] [eframe::web::app_runner] eframe/src/web/app_runner.rs:191: LOGIC [1920.0 993.0] ``` After: ``` [eframe::web::events] eframe/src/web/events.rs:633: ResizeObserver canvas=[300.0 150.0] to=(1920, 993) [eframe::web::app_runner] eframe/src/web/app_runner.rs:191: LOGIC [1920.0 993.0] [eframe::web::app_runner] eframe/src/web/app_runner.rs:191: LOGIC [1920.0 993.0] ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures the first animation frame happens after the resize observer has had a chance to do its job.
The first commit contains some
logcalls to observe the changed behavior:Before:
After: