Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context menu #543

Merged
merged 46 commits into from
Oct 26, 2021
Merged

Context menu #543

merged 46 commits into from
Oct 26, 2021

Commits on Oct 25, 2021

  1. Only drag with primary pointer button

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    01aea23 View commit details
    Browse the repository at this point in the history

  2. Add ContextMenuSystem for context menu 

    Listens for secondary click, support for sub-menus
    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    04e52be View commit details
    Browse the repository at this point in the history

  3. Syntax simplification in demo context menu builder

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    432ac9c View commit details
    Browse the repository at this point in the history

  4. Store ContextMenuSystem in Context and respect Ui clicked

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    185d86e View commit details
    Browse the repository at this point in the history

  5. Add context menu for widget_gallery plot

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    69a33d8 View commit details
    Browse the repository at this point in the history

  6. Fix menu being reset when clicking on it

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    28ef15d View commit details
    Browse the repository at this point in the history

  7. Adapt to removal of From conversions Vec2 <-> Pos2

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    1817b62 View commit details
    Browse the repository at this point in the history

  8. Apply context menu to Response

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    7011c37 View commit details
    Browse the repository at this point in the history

  9. Rename context_menu functions

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    3519508 View commit details
    Browse the repository at this point in the history

  10. Refactor

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    aa91812 View commit details
    Browse the repository at this point in the history

  11. Fix warnings

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    1da8097 View commit details
    Browse the repository at this point in the history

  12. Use response.clicked to detect clicks

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    171a818 View commit details
    Browse the repository at this point in the history

  13. Make MenuState::get_submenu private

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    a3f0c5e View commit details
    Browse the repository at this point in the history

  14. Improve submenu navigation by allowing crossing other items

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    3f49d85 View commit details
    Browse the repository at this point in the history

  15. Refactor and comment

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    2410c76 View commit details
    Browse the repository at this point in the history

  16. Prevent breaking of drag on attached elements

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    968233d View commit details
    Browse the repository at this point in the history

  17. Close submenu when pointer outside is not moving towards it 

    we need to request an extra repaint to detect if the pointer is still
even in reactive mode
    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    c40c120 View commit details
    Browse the repository at this point in the history

  18. Draw context menu using same Ui as egui::menu

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    ea27d7c View commit details
    Browse the repository at this point in the history

  19. Improve submenu style

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    0698b2b View commit details
    Browse the repository at this point in the history

  20. Fix submenu button flicker

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    3e0e7aa View commit details
    Browse the repository at this point in the history

  21. Better encapsulation of MenuState

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    f25e02f View commit details
    Browse the repository at this point in the history

  22. Remove Clone implementations

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    5e96b56 View commit details
    Browse the repository at this point in the history

  23. Some styling improvements

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    8c46041 View commit details
    Browse the repository at this point in the history

  24. Fix submenu text alignment

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    31e9fd4 View commit details
    Browse the repository at this point in the history

  25. Refactor, run cargo fmt

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    2a1ac41 View commit details
    Browse the repository at this point in the history

  26. Add function for adding items to submenus 

    this allows us to disable hover visuals when any
other entry is hovered
    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    ccbd1d2 View commit details
    Browse the repository at this point in the history

  27. Keep track of submenu index in parent context menu 

    this improves the Id's generated for submenus, as they will depend on
the index in their parent, rather than their position. This avoids
recreating an Id for the same conceptual submenu, only drawn at a
different position.
    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    dee2611 View commit details
    Browse the repository at this point in the history

  28. Refactoring

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    1697958 View commit details
    Browse the repository at this point in the history

  29. Add button padding to context menu

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    ae95f5f View commit details
    Browse the repository at this point in the history

  30. Don't return any Response from SubMenu::show 

    wasn't really needed so far and is probably better for encapsulation
    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    97c957a View commit details
    Browse the repository at this point in the history

  31. Define useful Response for SubMenu::show 

    an InnerResponse for the SubMenu button Response with an optional
inner Response for the extended SubMenu
    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    85d63b1 View commit details
    Browse the repository at this point in the history

  32. Open ContextMenu on pointer button press, not click 

    clicks only occur on button release, button press feels more responsive
    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    1238467 View commit details
    Browse the repository at this point in the history

  33. Refactoring: Apply PR Review

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    3ed068a View commit details
    Browse the repository at this point in the history

  34. cargo clippy

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    557184f View commit details
    Browse the repository at this point in the history

  35. Add MenuUi and demo window

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    5a31048 View commit details
    Browse the repository at this point in the history

  36. Remove MenuUi and manage MenuState in Ui

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    2f573a6 View commit details
    Browse the repository at this point in the history

  37. Use vscroll() instead of scroll()

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    b8fe011 View commit details
    Browse the repository at this point in the history

  38. submenus for normal egui:::menus

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    aef287b View commit details
    Browse the repository at this point in the history

  39. Fix stationary menus not closing when clicking elsewhere

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    88d3900 View commit details
    Browse the repository at this point in the history

  40. Rebase on emilk/egui@master

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    9f3af74 View commit details
    Browse the repository at this point in the history

  41. Fix stationary menu rect not being set

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    700b166 View commit details
    Browse the repository at this point in the history

  42. Apply review 

    - refactoring
- removed some demos
- add doctest for ui.menu_button()
- fixed menu_state not being cloned to child ui
    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    37ac070 View commit details
    Browse the repository at this point in the history

  43. Fix stationary menus not reacting to close_menu()

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    ffbf96f View commit details
    Browse the repository at this point in the history

  44. cargo fmt & clippy

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    a74dff7 View commit details
    Browse the repository at this point in the history

  45. Delete context_menu module

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    b54233c View commit details
    Browse the repository at this point in the history

  46. Run cargo clippy and cargo fmt

    @mankinskin
    mankinskin committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    3db6bdf View commit details
    Browse the repository at this point in the history