This repository has been archived by the owner on Dec 28, 2020. It is now read-only.
Adding underscore to the "exotic characters in the structure/template names" ;) #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You said in documentation:
There may be no exotic characters in the structure/template names (nothing which is not valid filename on an old Windows machine, so no slash, no comma, etc).
You make a replace of exotic characters using this regex (/[^a-zA-Z0-9 .-]/g, "") to nothing... but underscore character should be consider a valid "old windows" name... this cause we can update template (only download) because it replace RS_XXX_TEMPLATE to RSXXXTEMPLATE.
Thanks for this great tool.