Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dev dependency with failure #221

Closed
tatref opened this issue Dec 14, 2022 · 2 comments
Closed

Remove dev dependency with failure #221

tatref opened this issue Dec 14, 2022 · 2 comments

Comments

@tatref
Copy link
Contributor

tatref commented Dec 14, 2022

Hi,

Today, CI does not pass because of object release 0.30, that requires a recent compiler.

├── failure v0.1.8
│   ├── backtrace v0.3.67
│   │   ├── object v0.30.0

Here are the release notes (gimli-rs/object@ed03e05):

  • The minimum supported rust version for the read feature has changed to 1.52.0.
  • The minimum supported rust version for the write feature has changed to 1.61.0.

Also, failure is deprecated since 2020, they recommend to use anyhow or thiserror

failure is only used to test the functions signatures when they return Result for composition

How could we improve the situation?

@eminence
Copy link
Owner

It's getting increasingly hard to maintain the 1.48 MSRV in procfs. I've just opened #222 to try to fix this particular issue. I've also opened #223 to track the topic of MSRV for procfs

@eminence
Copy link
Owner

I'm going to close this, since our CI is now only testing against stable/beta/nightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants