Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSRV for procfs #223

Open
eminence opened this issue Dec 17, 2022 · 3 comments
Open

MSRV for procfs #223

eminence opened this issue Dec 17, 2022 · 3 comments

Comments

@eminence
Copy link
Owner

The procfs crate currently has a MSRV of 1.48, and this is verified via CI checks. However, it is increasingly difficult to actually test on 1.48 because more and more of the rust ecosystem will arbitrary change their MSRV (even in patch versions).

Our CI script is full of cargo pins to keep certain dependencies on older versions.

I am now strongly considering changing the MSRV of rust to be something way less conservative. I'm not sure exactly what it should be If anyone has any thoughts, please let me know

@eminence
Copy link
Owner Author

My current thinking du jour: the latest version of procfs will only be tested against the latest stable rust compiler.

But if someone needs to use procfs on an older compiler, we'll publish a table that lists what version of procfs they should use (for example, procfs v0.14 supports rust 1.48). If they need a specific bugfix backported to an older release of procfs, they can ask for that. And if they're willing to do the work, I think they can backport new features to older releases too.

@tatref
Copy link
Contributor

tatref commented Mar 3, 2023

This might be of interest: https://github.com/foresterre/cargo-msrv

@tyilo
Copy link

tyilo commented Oct 25, 2024

If you don't want to guarantee a specific MSRV, I think the rust-version field should be removed from Cargo.toml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants