Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-filter: replace GO_FILTER_OBJECT_FILE env var with disable flag #5097

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

haq204
Copy link

@haq204 haq204 commented Jun 8, 2023

Description

AMBASSADOR_DISABLE_GO_FILTER is an env var flag to disable injecting the go filter when running in EdgeStack mode. When running pure Emissary, the go-filter is not injected anyway. the library path is now kept hardcoded since there's no reason to really expose it to be configurable and was causing some confusion on naming.

Due to the presence of this flag now, we add it to the KAT/integration test manifests so that the go-filter isn't injected during those tests. This is fine for now because those tests are not testing any functionality from the go-filter. Future work will include overhauling the E2E test suite.

Also change the filter library path to /ambassador/filter.so since that's where the filter library file is located in the edgestack image.

Related Issues

List related issues.

Testing

CI

Checklist

  • Does my change need to be backported to a previous release?

    • What backport versions were discussed with the Maintainers in the Issue?
  • I made sure to update CHANGELOG.md.

    Remember, the CHANGELOG needs to mention:

    • Any new features
    • Any changes to our included version of Envoy
    • Any non-backward-compatible changes
    • Any deprecations
  • This is unlikely to impact how Ambassador performs at scale.

    Remember, things that might have an impact at scale include:

    • Any significant changes in memory use that might require adjusting the memory limits
    • Any significant changes in CPU use that might require adjusting the CPU limits
    • Anything that might change how many replicas users should use
    • Changes that impact data-plane latency/scalability
  • My change is adequately tested.

    Remember when considering testing:

    • Your change needs to be specifically covered by tests.
      • Tests need to cover all the states where your change is relevant: for example, if you add a behavior that can be enabled or disabled, you'll need tests that cover the enabled case and tests that cover the disabled case. It's not sufficient just to test with the behavior enabled.
    • You also need to make sure that the entire area being changed has adequate test coverage.
      • If existing tests don't actually cover the entire area being changed, add tests.
      • This applies even for aspects of the area that you're not changing – check the test coverage, and improve it if needed!
    • We should lean on the bulk of code being covered by unit tests, but...
    • ... an end-to-end test should cover the integration points
  • I updated DEVELOPING.md with any any special dev tricks I had to use to work on this code efficiently.

  • The changes in this PR have been reviewed for security concerns and adherence to security best practices.

…BLE_GO_FILTER

AMBASSADOR_DISABLE_GO_FILTER is an env var flag to disable injecting the go filter when running in EdgeStack mode. When running pure Emissary, the go-filter is not injected anyway. the library path is now kept hardcoded since there's not reason to really expose it to be configurable and was causing some confusion on naming.

Due to the presence of this flag now, we add it to the KAT/integration test manifests so that the go-filter isn't injected during those tests. This is fine for now because those tests are not testing any functionality from the go-filter. Future work will include overhauling the E2E test suite.

Signed-off-by: Hamzah Qudsi <[email protected]>
@haq204 haq204 marked this pull request as ready for review June 8, 2023 22:28
@haq204 haq204 merged commit faf3052 into master Jun 9, 2023
@haq204 haq204 deleted the hqudsi/go-filter-disable branch June 9, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants