Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When trying to run emissary in crypto-restricted environments (e.g. FIPS), usage of md5 can be problematic:
This replaces the usage with xxhash, which avoids the usage of md5 but keeps the same deterministic hash behavior. This was chosen over other stdlib hash functions that would be conformant (e.g. sha256) to minimize hash size since long hash length may be problematic for k8s name length restrictions (253 characters).
Related Issues
n/a
Testing
Updated unit tests.
Checklist
Does my change need to be backported to a previous release?
Shouldn't need backport.
I made sure to update
CHANGELOG.md
.Remember, the CHANGELOG needs to mention:
This is unlikely to impact how Ambassador performs at scale.
Remember, things that might have an impact at scale include:
My change is adequately tested.
Remember when considering testing:
I updated
CONTRIBUTING.md
with any special dev tricks I had to use to work on this code efficiently.The changes in this PR have been reviewed for security concerns and adherence to security best practices.