catch urllib3.exceptions.ProtocolError and continue watching #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kflynn
approved these changes
Aug 15, 2018
ambassador/kubewatch.py
Outdated
|
|
||
| logger.info("watch loop exited?") | ||
| except ProtocolError: | ||
| continue |
There was a problem hiding this comment.
Is it worth logging anything here?
There was a problem hiding this comment.
Sure. When the connection was lost and caught it, container should tell us that ambassador rewatched k8s automatically. I'll rewrite this to log a message as debug, and resend pull request. Thank you.
…and retry automatically
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #554
When
urllib3.exceptions.ProtocolErrorraised atwatch_loop, catch it and reconnect kubernetes to watch events.