Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few upgrades #5

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Few upgrades #5

wants to merge 6 commits into from

Conversation

bluesockets
Copy link

@bluesockets bluesockets commented Apr 13, 2017

Not ready for merge, needs some testing beyond my current use. Here's a rundown for what I've changed:

  • const -> import syntax
  • added default styles: font-size 12px, width 80, padding-left 5
  • column header style override support for font-size, margin-left, width -> (min-width, max-width, width)
  • support for ignoring extra columns data beyond configured header columns
  • converted some map functions to map lookups
  • added default header row id
  • added some styling to tighten up the headers
  • also added delete row icon and action

The project I'm working on needed some slight tweaks that could prove to be useful to the community. Let me know if you'd consider any of these changes - I'm happy to contribute whatever might be useful.

@emkay
Copy link
Owner

emkay commented Apr 27, 2017

awesome! thanks for contributing. a couple things that would be cool:

  1. const -> import syntax. I'd prefer to keep require syntax because the semantics of the module loader spec are a moving target. Ideally it wouldn't rely on babel stuff, or at least not babel-preset-es2015.

  2. the project is using standard-version to generate the changelog, which means the commit messages need to be made using the conventional commits spec.

I really should put this all down in a contributing.md file and have tests and all that setup. I don't really use this project much, but am willing to add you as a contributor.

@bluesockets
Copy link
Author

Sounds good. I'll apply your feedback - require syntax, removing babel-preset-es2015, as well as the changelog with some new commits. Happy to squash my commits for your final review as well.

I'm glad to help!

@emkay
Copy link
Owner

emkay commented May 29, 2017

@bluesockets I've setup travis-ci. There aren't any tests yet, but it does run the linter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants