Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: still use an in-memory cache even when loading/saving disabled #1280

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Aug 15, 2024

No description provided.

@emmercm emmercm self-assigned this Aug 15, 2024
@emmercm emmercm enabled auto-merge (squash) August 15, 2024 21:29
@emmercm emmercm merged commit 18507d4 into emmercm/3.0.0-feature Aug 15, 2024
55 checks passed
@emmercm emmercm deleted the emmercm/disabled-cache-still-use branch August 15, 2024 21:36
Copy link

🧪 Branch testing instructions

This pull request has been merged, its base branch can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/3.0.0-feature" [commands..] [options]

Comment generated by the Node.js Branch Exec workflow.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.62%. Comparing base (3188811) to head (684299b).
Report is 1 commits behind head on emmercm/3.0.0-feature.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           emmercm/3.0.0-feature    #1280      +/-   ##
=========================================================
- Coverage                  92.63%   92.62%   -0.02%     
=========================================================
  Files                        117      117              
  Lines                       7355     7345      -10     
  Branches                    1656     1773     +117     
=========================================================
- Hits                        6813     6803      -10     
  Misses                       541      541              
  Partials                       1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant