Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: prevent writer threads from exceeding the maximum #616

Merged
merged 4 commits into from
Aug 25, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Aug 25, 2023

No description provided.

@emmercm emmercm self-assigned this Aug 25, 2023
@emmercm emmercm enabled auto-merge (squash) August 25, 2023 03:39
@github-actions
Copy link

🧪 Branch Testing

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/fix-growing-writer-semaphore" [commands..] [options]

@codecov-commenter
Copy link

Codecov Report

Merging #616 (888af2f) into main (5072263) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #616      +/-   ##
==========================================
+ Coverage   93.62%   93.64%   +0.02%     
==========================================
  Files          77       77              
  Lines        4547     4547              
  Branches      979      979              
==========================================
+ Hits         4257     4258       +1     
+ Misses        276      275       -1     
  Partials       14       14              
Files Changed Coverage Δ
src/modules/candidateWriter.ts 89.44% <100.00%> (+0.45%) ⬆️

@emmercm emmercm merged commit b7e4bc2 into main Aug 25, 2023
46 checks passed
@emmercm emmercm deleted the emmercm/fix-growing-writer-semaphore branch August 25, 2023 20:16
@github-actions
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants