Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: create ROMProps interface #663

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Refactor: create ROMProps interface #663

merged 1 commit into from
Sep 18, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Sep 18, 2023

No description provided.

@emmercm emmercm self-assigned this Sep 18, 2023
@emmercm emmercm enabled auto-merge (squash) September 18, 2023 01:58
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #663 (b58a48b) into main (4e693b6) will decrease coverage by 0.41%.
The diff coverage is 86.20%.

@@            Coverage Diff             @@
##             main     #663      +/-   ##
==========================================
- Coverage   93.60%   93.20%   -0.41%     
==========================================
  Files          78       78              
  Lines        4594     4603       +9     
  Branches      993     1001       +8     
==========================================
- Hits         4300     4290      -10     
- Misses        279      297      +18     
- Partials       15       16       +1     
Files Changed Coverage Δ
src/types/logiqx/game.ts 97.45% <ø> (ø)
src/types/logiqx/rom.ts 88.57% <80.95%> (-11.43%) ⬇️
src/modules/candidatePatchGenerator.ts 95.00% <100.00%> (ø)
src/modules/datInferrer.ts 100.00% <100.00%> (ø)
src/modules/datScanner.ts 94.44% <100.00%> (ø)

... and 1 file with indirect coverage changes

@github-actions
Copy link

🧪 Branch Testing

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/rom-props" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm merged commit 1732918 into main Sep 18, 2023
50 checks passed
@emmercm emmercm deleted the emmercm/rom-props branch September 18, 2023 02:14
@github-actions
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant