Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data-diff first line bug #57

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Fix data-diff first line bug #57

merged 4 commits into from
Aug 22, 2023

Conversation

fry69
Copy link
Contributor

@fry69 fry69 commented Aug 22, 2023

Fix #56

  • diff symbol renders now inside the code block for the first line
  • added example for diff on the first line
  • tests desperately needed

I am happy with this so far, awaiting comments.

@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for ember-showdown-prism ready!

Name Link
🔨 Latest commit ea187dd
🔍 Latest deploy log https://app.netlify.com/sites/ember-showdown-prism/deploys/64e4c4a2f43c650008b2584d
😎 Deploy Preview https://deploy-preview-57--ember-showdown-prism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fry69 fry69 changed the title refactor diffInfo to function refactor diffInfo to function (WIP) Aug 22, 2023
@fry69 fry69 changed the title refactor diffInfo to function (WIP) Fix data-diff first line bug (WIP) Aug 22, 2023
@fry69 fry69 changed the title Fix data-diff first line bug (WIP) Fix data-diff first line bug Aug 22, 2023
@fry69
Copy link
Contributor Author

fry69 commented Aug 22, 2023

No clue how to fix this, I did not touch anything knowingly that could provoke an Ember is not defined error. Please enlighten me.

Built project successfully. Stored in "/tmp/tests-dist-2023722-1936-1ggxhms.oalu".
not ok 1 Chrome 115.0 - [undefined ms] - Global error: Uncaught ReferenceError: Ember is not defined at http://localhost:7357/assets/vendor.js, line 3860
    ---
        browser log: |
            {"type":"error","text":"Uncaught ReferenceError: Ember is not defined at http://localhost:7357/assets/vendor.js, line 3860\n","testContext":{}}

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an amazing change 🎉 thanks for the change. I would love you to remove the (?bug) comment but it's not a requirement for merging 👍

addon/initializers/showdown-extension.js Outdated Show resolved Hide resolved
@mansona
Copy link
Member

mansona commented Aug 22, 2023

@fry69 regarding the Embroider error, you can ignore it. It's because of a new embroider feature that was recently added in embroider-build/embroider#1521

I will fix that at a later date, and it's nothing that you have done to cause that issue

@mansona mansona merged commit 4eb76d8 into empress:main Aug 22, 2023
15 of 16 checks passed
@mansona mansona added the bug Something isn't working label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data-diff first line bug
2 participants