-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix data-diff first line bug #57
Conversation
✅ Deploy Preview for ember-showdown-prism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
No clue how to fix this, I did not touch anything knowingly that could provoke an
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an amazing change 🎉 thanks for the change. I would love you to remove the (?bug) comment but it's not a requirement for merging 👍
@fry69 regarding the Embroider error, you can ignore it. It's because of a new embroider feature that was recently added in embroider-build/embroider#1521 I will fix that at a later date, and it's nothing that you have done to cause that issue |
Fix #56
I am happy with this so far, awaiting comments.