-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emrun: Set COOP,COEP and CORP headers #10077
Conversation
Those Firefox flags can be set here: https://github.com/emscripten-core/emscripten/blob/incoming/emrun.py#L331 (add them to last position in the file, they need to be in chronological order of adoption) |
test_offset_converter is failing and I have no idea why 😓
can this be skipped here too? |
I've seen that error before, but not sure why it happens - seems random. I restarted those two jobs. If they don't pass now, please merge in latest incoming. If that doesn't fix things, then we'll need to do more serious investigation (separately from this PR). |
3af6fa6
to
6a43717
Compare
Hmm, in Firefox Nightly I see there is a field |
@juj that's mainly meant for testing, will never work on Release, and might eventually be redone in some manner. |
This enables emrun to serve pages by taking into account the upcoming restrictions on Content Policy for Firefox 72. In Firefox 71, we currently need to set these flags to test the upcoming feature: browser.tabs.remote.useCORP browser.tabs.remote.useCrossOriginOpenerPolicy browser.tabs.remote.useCrossOriginEmbedderPolicy dom.postMessage.sharedArrayBuffer.withCOOP_COEP
6a43717
to
55428c6
Compare
Great, thanks! |
Thanks @msabwat. |
* emrun: Set COOP,COEP and CORP headers This enables emrun to serve pages by taking into account the upcoming restrictions on Content Policy for Firefox 72. In Firefox 71, we currently need to set these flags to test the upcoming feature: browser.tabs.remote.useCORP browser.tabs.remote.useCrossOriginOpenerPolicy browser.tabs.remote.useCrossOriginEmbedderPolicy dom.postMessage.sharedArrayBuffer.withCOOP_COEP * fixup: remove semicolons
Hello!
I'm not sure what should I do. |
Hi, |
This enables emrun to serve pages by taking into account
the upcoming restrictions on Content Policy for Firefox 72.
In Firefox 71, we currently need to set these flags to test the
upcoming feature:
browser.tabs.remote.useCORP
browser.tabs.remote.useCrossOriginOpenerPolicy
browser.tabs.remote.useCrossOriginEmbedderPolicy
dom.postMessage.sharedArrayBuffer.withCOOP_COEP
This PR is a fwp on @VirtualTim ticket:
Fixes #10014