Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Atomics.wait to be called on the main thread for Node #12007

Merged
merged 2 commits into from
Aug 26, 2020

Conversation

kleisauke
Copy link
Collaborator

This restriction seems to apply only to browsers.

This restriction seems to apply only to browsers.
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please add a test. We have a few node-pthread tests in tests/test_core.py, annotated with @node_pthreads - maybe adding a little to one of them.

@kripken
Copy link
Member

kripken commented Aug 26, 2020

Nice test, thanks!

@kripken kripken merged commit 334c79c into emscripten-core:master Aug 26, 2020
kleisauke added a commit to kleisauke/emscripten that referenced this pull request Dec 4, 2020
kleisauke added a commit to kleisauke/emscripten that referenced this pull request Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants