Remove offset-converter run dependency. NFC
#14757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
fix_offset_converter_modularize
branch
from
c8307db
to
00096d9
Compare
sbc100
force-pushed
the
limit_run_dependencies
branch
from
a8017bd
to
37c46db
Compare
sbc100
force-pushed
the
limit_run_dependencies
branch
2 times, most recently
from
1de42f6
to
63361f7
Compare
sbc100
changed the title
offset-converter run dependency when actually needed. NFCoffset-converter run dependency. NFC
sbc100
force-pushed
the
limit_run_dependencies
branch
3 times, most recently
from
9ba935d
to
f41191a
Compare
kripken
approved these changes
Jul 27, 2021
src/preamble.js
Outdated
| return WebAssembly.instantiate(binary, info); | ||
| }).then(function (instance) { | ||
| #if USE_OFFSET_CONVERTER | ||
| // See comment below in instantiateAsync |
There was a problem hiding this comment.
Which comment does this refer to? If it's for We need the wasm binary for the offset converter .. then I'm not sure how it's related?
There was a problem hiding this comment.
The one on line 1139: When using the offset converter, we must interpose here..
Basically we can't call receiver before we have assigned wasmOffsetConverter .. for the same reason as on line 1139. I believe you fixed this in #14611 for the normal instantiateAsync but not for the fallback instantiateArrayBuffer.
sbc100
force-pushed
the
limit_run_dependencies
branch
from
f41191a
to
1bc8d45
Compare
Following up on the change made in #14611, this change forces the `WasmOffsetConverter` before calling receiveInstantiationResult in both code paths (instantiateArrayBuffer and instantiateAsync). With that done (along with #14755) there are no more valid use cases for to block execution based on the absence of `WasmOffsetConverter`. By the time the instance is received it is always defined.
sbc100
force-pushed
the
limit_run_dependencies
branch
from
1bc8d45
to
f3d62d6
Compare
kripken
approved these changes
Jul 27, 2021
Co-authored-by: Alon Zakai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
offset-converterrun dependency. NFCFollowing up on the change made in #14611, this change forces the
WasmOffsetConverterbefore calling receiveInstantiationResult in bothcode paths (instantiateArrayBuffer and instantiateAsync).
With that done (along with #14755) there are no more valid use cases for
to block execution based on the absence of
WasmOffsetConverter. Bythe time the instance is received it is always defined.