Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment with node issue in streams.cpp #15631

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

ethanalee
Copy link
Collaborator

Updated comment to link ongoing issue with Node: nodejs/node#40961

Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure it's specific to PROXY_TO_PTHREAD? I tested that way for convenience, but I'm not sure it's not present without that mode. But the comment lgtm as that might be the most common way to encounter the issue.

@ethanalee
Copy link
Collaborator Author

Are you sure it's specific to PROXY_TO_PTHREAD? I tested that way for convenience, but I'm not sure it's not present without that mode. But the comment lgtm as that might be the most common way to encounter the issue.

I can just specify that this is the most common failure mode. 👍

@ethanalee ethanalee enabled auto-merge (squash) November 25, 2021 00:44
@ethanalee ethanalee merged commit 9297133 into main Nov 25, 2021
@ethanalee ethanalee deleted the wasmfs-out-err-workaround branch November 25, 2021 01:42
mmarczell-graphisoft pushed a commit to GRAPHISOFT/emscripten that referenced this pull request Jan 5, 2022
Updated comment to link ongoing issue with Node: nodejs/node#40961
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants