Cleanup serialization of settings JSON file. NFC #15912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sbc100
commented
Jan 7, 2022
sbc100
commented
- Use .json extension
- Avoid seralizing entire LEGACY_SETTINGS
- Use indentation to make the file readable.
- Refactor JS settings file reading to avoid duplication.
- Use .json extension - Avoid seralizing entire LEGACY_SETTINGS - Use indentation to make the file readable. - Refactor JS settings file reading to avoid duplication.
sbc100
force-pushed
the
cleanup_settings_serialize
branch
from
b4023c3
to
ae69fd0
Compare
kripken
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.