More use of JS method syntax. NFC

[sbc100]

No description provided.

[jameshu15869]

Just to check, is the method syntax or arrow syntax preferred? It looks like there were some functions in library_wasmfs.js that were left as arrow functions (e.g. close, mkdir). Is there a specific reason that arrow syntax was used in those cases and not for the other methods? It looks like the arrow syntax methods were basically all inside FS.handleError() so should I use arrow functions for one line returns and method syntax for the others in the future?

[sbc100]

I think the answer is that we should probably prefer whichever produces the smallest code size. In almost all cases that is method syntax so we should, in general prefer that.

I think the only exception is single expression functions that return a value. In this case we can use the short-form of the arrow syntax that avoids the return keyword. If that ends up being too confusing of a rule then I think we should prefer method syntax everywhere.. especially since it avoid the this binding issue that arrow functions have.

[jameshu15869]

Got it. Is there a measurement for code size in JS files like metadce_files_wasmfs.size? Or would it more be based on character count/lines taken up in the JS file itself?

[sbc100]

Yes, the measurement of code size here comes from the metadce and other codesize tests in the test_other.py. To see the effect of a given change on code size I normally run ./test/runner other.*code_size* other.*metadce* --rebase.