-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hi DPI Support for GLFW #20584
Add Hi DPI Support for GLFW #20584
Commits on Oct 29, 2023
-
- added Browser.isHiDPIAware flag that gets initialized from Module.isHiDPIAware - from the webgpu samples (https://webgpu.github.io/webgpu-samples/samples/helloTriangle), the gist of the logic is to scale canvas.width (resp. canvas.height) by the devicePixelRatio and set canvas.clientWidth to the width - coordinates are then scaled down to reflect what the client is expecting
Configuration menu - View commit details
-
Copy full SHA for 811ef54 - Browse repository at this point
Copy the full SHA 811ef54View commit details -
- calling Browser.requestFullscreen raises "Failed to execute 'requestFullscreen' on 'Element': API can only be initiated by a user gesture"
Configuration menu - View commit details
-
Copy full SHA for 7c457a4 - Browse repository at this point
Copy the full SHA 7c457a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c0e378 - Browse repository at this point
Copy the full SHA 6c0e378View commit details
Commits on Oct 30, 2023
-
Make sure it works for "default" shell
- handle case where the canvas size is fixed (default shell) - handle case where request full screen is issued by the user (default shell)
Configuration menu - View commit details
-
Copy full SHA for cbeb0e1 - Browse repository at this point
Copy the full SHA cbeb0e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba13c6f - Browse repository at this point
Copy the full SHA ba13c6fView commit details
Commits on Nov 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9f7a2a2 - Browse repository at this point
Copy the full SHA 9f7a2a2View commit details -
[PR Review]: Reverting changes (separate issue)
- created issue emscripten-core#20600 to implement in a separate PR
Configuration menu - View commit details
-
Copy full SHA for 454cd0f - Browse repository at this point
Copy the full SHA 454cd0fView commit details -
[PR Review]: getting rid of initialization
- the rationale is that the client can simply call Module.setHiDPIAware based on the needs
Configuration menu - View commit details
-
Copy full SHA for 15f1ff1 - Browse repository at this point
Copy the full SHA 15f1ff1View commit details -
- ironically, although the call was wrong, it ended up doing the right thing...
Configuration menu - View commit details
-
Copy full SHA for e38a34c - Browse repository at this point
Copy the full SHA e38a34cView commit details
Commits on Nov 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b291873 - Browse repository at this point
Copy the full SHA b291873View commit details
Commits on Nov 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 51f3288 - Browse repository at this point
Copy the full SHA 51f3288View commit details
Commits on Nov 6, 2023
-
Merge remote-tracking branch 'origin/main' into hi-dpi-aware
# Conflicts: # src/library_browser.js
Configuration menu - View commit details
-
Copy full SHA for 08a5b69 - Browse repository at this point
Copy the full SHA 08a5b69View commit details
Commits on Nov 7, 2023
-
- mocking devicePixelRatio allow to write a comprehensive test - added handling dynamic changes to devicePixelRatio by installing a listener
Configuration menu - View commit details
-
Copy full SHA for f4320c3 - Browse repository at this point
Copy the full SHA f4320c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 875f440 - Browse repository at this point
Copy the full SHA 875f440View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91aa2ad - Browse repository at this point
Copy the full SHA 91aa2adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 80b982b - Browse repository at this point
Copy the full SHA 80b982bView commit details
Commits on Nov 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7d4fdcd - Browse repository at this point
Copy the full SHA 7d4fdcdView commit details -
Configuration menu - View commit details
-
Copy full SHA for c30e05e - Browse repository at this point
Copy the full SHA c30e05eView commit details
Commits on Nov 14, 2023
-
Merge remote-tracking branch 'origin/main' into hi-dpi-aware
# Conflicts: # src/library_glfw.js
Configuration menu - View commit details
-
Copy full SHA for f73c502 - Browse repository at this point
Copy the full SHA f73c502View commit details -
- Browser.setCanvasSize sets win.width and win.height already so it should not be overridden afterwards - Browser.setCanvasSize also triggers the win.windowSizeFunc callback when appropriate (window size has actually changed)
Configuration menu - View commit details
-
Copy full SHA for 6ff6773 - Browse repository at this point
Copy the full SHA 6ff6773View commit details
Commits on Nov 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 11d5832 - Browse repository at this point
Copy the full SHA 11d5832View commit details
Commits on Nov 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 241e027 - Browse repository at this point
Copy the full SHA 241e027View commit details -
- now GLFW use GLFW_SCALE_TO_MONITOR during window creation to determine hi dpi awareness - Module.setHiDPIAware is only set when using GLFW (making sure that other platforms don't accidentally use it)
Configuration menu - View commit details
-
Copy full SHA for f3de65e - Browse repository at this point
Copy the full SHA f3de65eView commit details
Commits on Nov 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a999fd0 - Browse repository at this point
Copy the full SHA a999fd0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7cc2f59 - Browse repository at this point
Copy the full SHA 7cc2f59View commit details -
Configuration menu - View commit details
-
Copy full SHA for a81f9a0 - Browse repository at this point
Copy the full SHA a81f9a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80be65a - Browse repository at this point
Copy the full SHA 80be65aView commit details
Commits on Nov 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 86aff8e - Browse repository at this point
Copy the full SHA 86aff8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 73f6b2f - Browse repository at this point
Copy the full SHA 73f6b2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ae7e31 - Browse repository at this point
Copy the full SHA 4ae7e31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95a6918 - Browse repository at this point
Copy the full SHA 95a6918View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a7e2ab - Browse repository at this point
Copy the full SHA 7a7e2abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2365d0e - Browse repository at this point
Copy the full SHA 2365d0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f4f37f - Browse repository at this point
Copy the full SHA 1f4f37fView commit details
Commits on Dec 1, 2023
-
use GLFW_SCALE_TO_MONITOR dynamically
- removed function from module - simply use glfwSetWindowAttrib instead
Configuration menu - View commit details
-
Copy full SHA for 767676a - Browse repository at this point
Copy the full SHA 767676aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d29c8d - Browse repository at this point
Copy the full SHA 9d29c8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for eb2dbf9 - Browse repository at this point
Copy the full SHA eb2dbf9View commit details
Commits on Dec 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 66c6e2a - Browse repository at this point
Copy the full SHA 66c6e2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4187761 - Browse repository at this point
Copy the full SHA 4187761View commit details -
Configuration menu - View commit details
-
Copy full SHA for 822f55d - Browse repository at this point
Copy the full SHA 822f55dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a58de4 - Browse repository at this point
Copy the full SHA 8a58de4View commit details
Commits on Dec 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for be0979e - Browse repository at this point
Copy the full SHA be0979eView commit details -
Merge remote-tracking branch 'origin/main' into hi-dpi-aware
# Conflicts: # src/library_glfw.js
Configuration menu - View commit details
-
Copy full SHA for 1b87dd7 - Browse repository at this point
Copy the full SHA 1b87dd7View commit details
Commits on Dec 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a3fb66d - Browse repository at this point
Copy the full SHA a3fb66dView commit details