-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] #20600 : Calling GLFW.setWindowSize with the screen size leads to browser error #20699
Merged
sbc100
merged 2 commits into
emscripten-core:main
from
ypujante:glfw-remove-auto-fullscreen
Nov 13, 2023
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the
Browser.exitFullscreen();
thing... should explictly setting the windows size also not exit fullscreen?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good question. SDL does not do it. glut does it. In my opinion SDL is right. When
Browser.requestFullscreen
is called, afullscreenchange
listener is put in place to detect exiting full screen (the user pressing ESC, or whatever key triggers that).Calling
Browser.exitFullscreen();
might trigger an error for the same reason thatBrowser.requestFullscreen
can (if the code callsglfwSetWindowSize
while in fullscreen mode but not from a user triggered event).I believe the proper way for the client code to handle this is to set a
Module.onFullScreen
callback which gets called whenever the browser goes in/out of fullscreen and then callglfwSetWindowSize
.I actually used this technique in my code this morning:
That being said, if you prefer to leave it, I believe the chances of getting an error are lower and probably have less consequences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I think being consistent with SDL and glut makes more sense.