Fix AUDIO_WORKLET + MODULARIZE

[sbc100]

Fixes: #21908

[sbc100]

Verified fix using interactive tests

[kripken]

Can you please explain why renaming this makes a difference? I can't figure it out.

[MuTsunTsai]

@kripken Looks like the key is adding await in this line:

emscripten/src/audio_worklet.js

Line 164 in a36f43c

globalThis.Module = await AudioWorkletModuleFactory(Module);

[juj]

LGTM, but has there been a semantics change to how MODULARIZE works? The await there is surprising to me.

[sbc100]

LGTM, but has there been a semantics change to how MODULARIZE works? The await there is surprising to me.

With MODULARIZE the constructor functions has always returned a Promise of a module (IIUC, thats the main difference between MODULARIZE and now removed MODULARIZE_INSTANCE).

There was a semantic change back in #21775 where the argument passed into the module constructor was not modified in-place.. this avoids leaking the module before the promise resolves.

[sbc100]

Can you please explain why renaming this makes a difference? I can't figure it out.

Sorry the rename is unrelated. I will revert that.

[sbc100]

Hopefully all these code will be removed soon anyway once I figure out how to inline the ww.js and aw.js files like I did for the pthread worker.js

[sbc100]

Simplified this PR by removing the rename. PTAL.

[kripken]

Thanks @MuTsunTsai , I missed that part among the rest of the diff...

[kripken]

Can we add a test for this?

[sbc100]

Can we add a test for this?

This failure was already showing up but only in the interactive tests... so it was already tests, just not by CI tests (that same goes for pretty much all our audio tests).