Micro-optimize emscripten_request_animation_frame_loop() #22503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type is void, so avoid redundant return, and hoist the getWasmTableEntry() call to occur only once up front.
juj
force-pushed
the
micro_optimize_request_animation_frame_loop
branch
from
8ee112d
to
a575dcf
Compare
sbc100
approved these changes
Sep 4, 2024
kripken
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Micro-optimize emscripten_request_animation_frame_loop(): the return type is void, so avoid redundant return, and hoist the getWasmTableEntry() call to occur only once up front.