Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Enable --rebaseline with browser reftests. NFC #22600

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Sep 20, 2024

These allows us to update the reference images quickly and easily
directly from the commandline.

To test that it works I ran ./test/runner browser.test_webgl_multi_draw_arrays --rebaseline
and checked in the resulting change.

@sbc100 sbc100 closed this Sep 20, 2024
@sbc100 sbc100 reopened this Sep 20, 2024
@sbc100 sbc100 changed the title [test] Refactor btest so it doesn't need to know about reftesting. NFC [test] Enable --rebaseline with browser reftests. NFC Sep 20, 2024
@sbc100 sbc100 force-pushed the reftest_rebase branch 3 times, most recently from d5479d7 to 4045caa Compare September 20, 2024 16:41
@kripken
Copy link
Member

kripken commented Sep 20, 2024

Nice idea!

@sbc100 sbc100 enabled auto-merge (squash) September 20, 2024 17:37
These allows us to update the reference images quickly and easily
directly from the commandline.
@sbc100 sbc100 merged commit 8eb432e into emscripten-core:main Sep 20, 2024
28 checks passed
@sbc100 sbc100 deleted the reftest_rebase branch September 20, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants