Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fall back on requests module when urllib fails to load a URL #8667

Merged
merged 2 commits into from
May 24, 2019
Merged

Fall back on requests module when urllib fails to load a URL #8667

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0457ca3
Fall back on requests module when urllib fails to load a URL
dschuff May 23, 2019
41d2da8
try requests first
dschuff May 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions tools/system_libs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -925,12 +925,20 @@ def retrieve():
# retrieve from remote server
logger.warning('retrieving port: ' + name + ' from ' + url)
try:
from urllib.request import urlopen
import requests
response = requests.get(url)
data = response.content
except ImportError:
# Python 2 compatibility
from urllib2 import urlopen
f = urlopen(url)
data = f.read()
try:
from urllib.request import urlopen
f = urlopen(url)
data = f.read()
except ImportError:
# Python 2 compatibility
from urllib2 import urlopen
f = urlopen(url)
data = f.read()

open(fullpath, 'wb').write(data)
State.retrieved = True

Expand Down