Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all costomizations are saved, eg WW.... is only saved partitially #1188

Closed
harvey637 opened this issue Jun 4, 2023 · 4 comments
Closed
Labels
bug Something isn't working
Milestone

Comments

@harvey637
Copy link

harvey637 commented Jun 4, 2023

Setting:
I use EMS-ESP connected Bosch Heatpump 7400i ONLY for heating, not for pool and not for WARMWATER.

When I customize the heatpump and the thermostat I select all "WW" values and deselect them from gui and api, ok.
After update/reboot SOME of the WW.... values are back again.

I see them in the downloaded costomization configuration:

         "03damping",
          **"03/wwsettemp",**
          "03/wwmode",
          "03/wwsettemplow",
          "03/wwcircmode",
          "03/wwchargeduration|<3810",
          "03/wwcharge",
          "03/wwextra1",
          "03/wwextra2",
          "03/wwdisinfecting",
          "03/wwdisinfectday",
          "03/wwdisinfecttime|<1431",
          "03hybridstrategy",
          "03switchovertemp",
          "03energycostratio|>0<20",
          "03fossilefactor",
          "03electricfactor",
          "03delayboiler",

but they all start with "03/ww ......" not like the other eg "03fossilefactor".
These "/ww..." values are not related to "hc1" like "03hc1/wwprio", which is handled correctly (not shown in gui and api) after reboot.

So all this "03/ww....." WITH THE SLASH are NOT evaluated for the gui and api customization. THis is part of the customization for a thermostat.

With boiler it gets a bit confusing:

          "03elheatstep1",
          "03elheatstep2",
          "03elheatstep3",
          "03ww/wwalternatingop",
          "03ww/wwaltopprioheat|>20<120",
          "03ww/wwaltopprioww|>30<120",
          "03ww/wwcomfoff|>15<65",
          "03ww/wwecooff|>15<65",

Here all the missing (not saved/reloaded) variables start with "ww/ww...". So it looks to me, that some code was added to handle the warmwater similar to an "hc1" sublevel. But both the single slash "03/ww... in thermostat nor the "03ww/ww..." in boiler work as expected.

Selecting "WW" in customization dialog lets me disable gui/api and push the save button. Until the next reboot everything is ok.
But it is not saved (and read) in the customization down/upload file.

No big deal (no usefull infos there), but it annoingly initiates useless creating the ww-variables in iobroker with iobroker.ems-esp adapter.

Bye the way: the old info regarding the translation of "hours" -> "Stunden" is still misleading in silentfrom/silentto. The value
"22 Stunden" really mean in german "22:00 Uhr" (which is 22:00 o`clock" in 24h) , just cosmetic, but now a bit confusing.

Thank You
Harvey

@proddy proddy added the bug Something isn't working label Jun 4, 2023
@proddy proddy added this to the v3.6.0 milestone Jun 4, 2023
@proddy
Copy link
Contributor

proddy commented Jun 4, 2023

yes, this looks incorrect. On which version are you on?

@harvey637
Copy link
Author

I am on 3.6.0-dev12, but it is present since "a long time" :-)

@MichaelDvP
Copy link
Contributor

There is a wrong "ww"-tag generated here
https://github.com/emsesp/EMS-ESP32/blob/46578dbe699987c66382cb9b014ce915e2f8a09e/src/emsdevice.cpp#LL1133C16-L1133C16
it should be
if (dv.tag >= DeviceValueTAG::TAG_HC1) {

MichaelDvP added a commit that referenced this issue Jun 4, 2023
@harvey637
Copy link
Author

Hi at superfast MichaelDvP and Proddy,
tested dev-12 after fix 1188 - looking very good!!!!!

No more "03/ww...." in thermostat and no more "03ww/ww..." in boiler configuration file.

have a very nice (last hours somewhat :-) of this weekend!
cu
Harvey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants