-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timestamp in MQTT shower message #1329
Comments
@MichaelDvP said: "If the esp32-RTC isproper set by NTP, thermostat or manual we can add it. {"duration":600, |
I think time in HH:MM:SS is universal and ok. It's just for displaying in the Home Assistant dashboard. |
A timestamp (seconds since epoch) would avoid timezone issues. Otherwise |
@MichaelDvP shall you add or I? |
For the publish it's only
but for the HA config it's better you add it to test and choose the right types. |
thanks, I'll add and do a PR now. Along with #1323 |
From the discussion #1328 started by @sciurius
he said in HA we use the
last-updated
property of the sensor to determine the timestamp. Sometimes it's not accurate and would be nicer to add the timestamp to theshower_data
MQTT payload which is persisted.The text was updated successfully, but these errors were encountered: