some refactoring and change #1297 #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
haven't really tested this though, will do that next. Wanted to get the PR in first as is touches a lot of files. |
MichaelDvP
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
It's to much to read/check every change, i just merged and checked on a esp. Looks ok.
The "no entries" message should also go to scheduler, temperaturesensor and analogsensor. I have this in my dev2-test, so we can add later with the power entities.
Only the analogsensor have a enable setting (is this usefull?), so it should give error message if disabled and "no entries" if enabled.
|
good catch, I forgot about the scheduler, temperaturesensor and analogsensor and it should have consistent behaviour. I'll merge now so you can continue with your updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the C++ code we were using class and object names like 'customEntity' in the Customizations logic, which was getting confused with the new Custom Entity feature. So I renamed the classes, objects, descriptors so you can tell if its Customization or CustomEntity piece of code.