Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global names to Dallas sensors to avoid ugly <unknown> and other … #27

Merged
merged 2 commits into from
Mar 16, 2021

Conversation

FauthD
Copy link

@FauthD FauthD commented Mar 16, 2021

…issues in HA

Hi Proddy,
you have asked to resend the PR from a fresh fork (cloned new ESP32 repo).

Many regards, DIeter Fauth

@FauthD
Copy link
Author

FauthD commented Mar 16, 2021

Hi Proddy,
looks like github collects further commits/pushes after I send the PR.

The "Add stuff to gitignore, add vscode workspace" was planned as a separate PR.

vscode workspace makes it easier to start fresh.

.gitignore now has two more files that are created by npm

  • .directory which is used by KDE for colored folders.

What I see is that "/interface/package-lock.json" is modified by npm. So after running it, the local copy is dirty (changed).
That kills automated version string creation (which I did not see in your project, but I am used to that since +20 years).
Not sure what can be done against it. Just wanted to mention it.

Dieter

@proddy proddy merged commit 478e636 into emsesp:main Mar 16, 2021
@proddy
Copy link
Contributor

proddy commented Mar 16, 2021

I've updated the gitignore. The package stuff has to stay in and there's a GitHub bot that will keep that up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants