WRQ-11247: Added fontScale prop for large text mode scale values #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enact-DCO-1.0-Signed-off-by: Hyelyn Kim ([email protected])
Enact-DCO-1.0-Signed-off-by: Hyelyn Kim ([email protected])
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1574 +/- ##
========================================
Coverage 81.44% 81.44%
========================================
Files 148 148
Lines 6629 6629
Branches 1955 1955
========================================
Hits 5399 5399
Misses 936 936
Partials 294 294 ☔ View full report in Codecov by Sentry. |
Enact-DCO-1.0-Signed-off-by: Hyelyn Kim ([email protected])
juwonjeong
reviewed
Mar 12, 2024
|
Please check the console error to fix the prop bleeding in sampler. |
- Delete fontScale from ThemeDecorator's config It only needs to be passed as a prop, not as a ThemeDecorator config Enact-DCO-1.0-Signed-off-by: Hyelyn Kim ([email protected])
Fixed. |
Enact-DCO-1.0-Signed-off-by: Hyelyn Kim ([email protected])
- FontScale must be updated before the scale function is called Enact-DCO-1.0-Signed-off-by: Hyelyn Kim ([email protected])
Enact-DCO-1.0-Signed-off-by: Hyelyn Kim ([email protected])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
There is a requirement for large text mode for a11y.
I have modified the app (including sampler) to review the screen when large text is applied.
Resolution
Added the fontScale prop to ThemeDecorator so that i can adjust the scale in the app.
Additional Considerations
Links
WRQ-11247
Comments
Enact-DCO-1.0-Signed-off-by: Hyelyn Kim ([email protected])