Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRR-5248: Convert ThemeDecorator to functional component #1712

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

adrian-cocoara-lgp
Copy link
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Migrated ThemeDecorator to functional component

Resolution

Removed class extends React.Component
Replaced componentDidMount and componentWillUnmount with useEffectHook

Additional Considerations

Links

WRR-5248

Comments

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.59%. Comparing base (5a4fd0d) to head (cf6ac19).

Files with missing lines Patch % Lines
ThemeDecorator/ThemeDecorator.js 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1712      +/-   ##
===========================================
- Coverage    81.59%   81.59%   -0.01%     
===========================================
  Files          148      148              
  Lines         6677     6676       -1     
  Branches      1987     1987              
===========================================
- Hits          5448     5447       -1     
  Misses         936      936              
  Partials       293      293              
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants