Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRR-6380: Converted Popup/Popup to functional component #1734

Open
wants to merge 27 commits into
base: develop
Choose a base branch
from

Conversation

ion-andrusciac-lgp
Copy link
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

At this moment, Popup/Popup is a hoc based on a class component. The goal is to convert it to a functional component.

Resolution

Converted Popup/Popup to functional component

Additional Considerations

Links

WRR-6380

Comments

Enact-DCO-1.0-Signed-off-by: Ion Andrusciac [email protected]

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 90.62500% with 9 lines in your changes missing coverage. Please review.

Project coverage is 80.89%. Comparing base (067a69b) to head (120af63).

Files with missing lines Patch % Lines
Popup/Popup.js 90.62% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1734      +/-   ##
===========================================
+ Coverage    80.81%   80.89%   +0.08%     
===========================================
  Files          148      148              
  Lines         6681     6690       +9     
  Branches      1986     1987       +1     
===========================================
+ Hits          5399     5412      +13     
+ Misses         973      970       -3     
+ Partials       309      308       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant