Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove css-stylus-with-nib tech #83

Merged
merged 2 commits into from
Jul 15, 2015
Merged

Remove css-stylus-with-nib tech #83

merged 2 commits into from
Jul 15, 2015

Conversation

gela-d
Copy link
Contributor

@gela-d gela-d commented Jun 26, 2015

Close #65

@gela-d gela-d added the review label Jun 26, 2015
@blond
Copy link
Member

blond commented Jun 26, 2015

Перед тем как удалять эту технологию, нужно поддержать возможность использовать nib через технологию stylus. Возможно, с помощью includes опции.

@gela-d
Copy link
Contributor Author

gela-d commented Jun 26, 2015

Тогда пока так
via #54

@blond blond added ready and removed review labels Jun 30, 2015
@tavriaforever
Copy link
Contributor

@blond Добавил опцию useNib + тесты на опцию

if (this._useNib) {
renderer
.use(nib())
.import(this.node.relativePath('node_modules/nib'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А почему import, а не include?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Потому что это разные штуки. include добавляет относительный путь для резолва уже существующих @import и url(), а import создает и вставляет @import, все равно, чтобы мы написали прямо в самом styl файле @import "node_modules/nib"
дока по этому вопросу https://github.com/stylus/stylus/blob/master/docs/js.md#includepath

@tavriaforever
Copy link
Contributor

@blond update PR

@blond
Copy link
Member

blond commented Jul 15, 2015

@tavriaforever, соскваш коммиты.

blond added a commit that referenced this pull request Jul 15, 2015
Remove `css-stylus-with-nib` tech
@blond blond merged commit 01e9d5e into master Jul 15, 2015
@blond blond removed the ready label Jul 15, 2015
@blond blond deleted the issue-65 branch July 15, 2015 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants