This repository has been archived by the owner on Feb 25, 2022. It is now read-only.
Support user defined formatters for validators #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose formatters on validators allowing the use of custom formatters as opposed to just the hard-coded date / datetime formats currently available.
This allows a validator to serialize from a json value to any native type and back again, so long as it is defined on the formatter. The motivation behind this was initially to enable porting DRF's PrimaryKeyRelatedField and SlugRelatedField to APIStar to better enable ORM support for 3rd party libraries