Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sni_hostname extension with SOCKS proxy #773

Closed
wants to merge 7 commits into from

Conversation

Allgot
Copy link
Contributor

@Allgot Allgot commented Aug 8, 2023


Co-authored-by: Tom Christie [email protected]

Summary

A new extension, sni_hostname has enalbed users to specify the hostname which would be used during TLS handshake. However, the update was inconsistent, resulting in the incomplete extension. Currently, the sni_hostname extension are not handled if SOCKS proxy is in use. This PR would bridge this gap.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@Allgot
Copy link
Contributor Author

Allgot commented Aug 8, 2023

Sorry for the confusing PR. I created a new branch from the HEAD by mistake.

I would close this PR right now, then create new one properly. Sorry.

@Allgot Allgot closed this Aug 8, 2023
@Allgot Allgot deleted the support-sni-hostname-with-socks branch August 8, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants