Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 to our test matrix. #807

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Sep 17, 2023

Summary

The second Python 3.12 release candidate is out! 🚀

Call to action

We strongly encourage maintainers of third-party Python projects to prepare their projects for 3.12 compatibilities during this phase, and where necessary publish Python 3.12 wheels on PyPI to be ready for the final release of 3.12.0.

Python 3.12.0 final is due out in two weeks: 2023-10-02.

See also https://dev.to/hugovk/help-test-python-312-beta-1508/

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😊

@tomchristie tomchristie merged commit 6071ea7 into encode:master Sep 18, 2023
5 checks passed
@karpetrosyan
Copy link
Member

Did you forget a changelog?

@tomchristie
Copy link
Member

Okay let me slow this down a little and be more precise.

First up, we should change the title of this PR...

@tomchristie tomchristie changed the title Add support for Python 3.12 Add Python 3.12 to our test matrix. Sep 18, 2023
@tomchristie
Copy link
Member

...okay that's better.

@tomchristie
Copy link
Member

Did you forget a changelog?

Good thing to check, thanks. No we don't need a CHANGELOG entry here.
We're not adding 3.12 support, we're including it in our CI tests.

@hugovk
Copy link
Contributor Author

hugovk commented Sep 18, 2023

This PR also added the Trove classifier for 3.12, which could be seen as adding 3.12 support?

I think it's a good time to add it: the final 3.12 RC3 is due out today, the full release in two weeks, and there should be no changes between now and then, and no ABI changes allowed.

@tomchristie
Copy link
Member

This PR also added the Trove classifier for 3.12, which could be seen as adding 3.12 support?

Ah thats a good point, thanks @hugovk.

Yes a CHANGELOG entry noting that our package now explicitly indicates 3.12 support would be valid.

Related... anyone up for an equivalent pull request to httpx?

@hugovk
Copy link
Contributor Author

hugovk commented Sep 19, 2023

This PR also added the Trove classifier for 3.12, which could be seen as adding 3.12 support?

Ah thats a good point, thanks @hugovk.

Yes a CHANGELOG entry noting that our package now explicitly indicates 3.12 support would be valid.

Here we go! #810

Related... anyone up for an equivalent pull request to httpx?

And here we go again! encode/httpx#2854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants