Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right, there was some stuff I didn't quite get correct in #89
Absurdly I'd forgotten to use
http2=True
in my testings. This is the script I'm using now for this...The changes here are:
stream_id = self.h2_state.get_next_available_stream_id()
needs to be part of the semaphore-limited wrapped code, or else it stops incrementing once we've hit the concurrency limit. As a result I've moved the wrapping layer out fromAsyncHTTP2Stream
ontoAsyncHTTP2Connection
instead.