Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling ruff C416 #3001

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Enabling ruff C416 #3001

merged 5 commits into from
Dec 13, 2023

Conversation

jamesbraza
Copy link
Contributor

@jamesbraza jamesbraza commented Dec 12, 2023 •
edited
Loading

Summary

I decided to decompose my PR on incorporating itertools.chain a bit, and some of it can be automated by C416. So this PR enables C416 in ruff to simplify code.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

tomchristie
tomchristie reviewed Dec 13, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
tomchristie
tomchristie approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, that's neater.

@tomchristie tomchristie merged commit 2318fd8 into encode:master Dec 13, 2023
5 checks passed
@tomchristie
Copy link
Member

I've left the config simple (the less config options the better) but included the suggested changes.
Thanks. 🙏

@jamesbraza jamesbraza deleted the adding-C416 branch December 13, 2023 17:07
@jamesbraza
Copy link
Contributor Author

Okay sounds good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbraza @tomchristie