Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add httpx.Version configuration. #3051

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Add httpx.Version configuration. #3051

wants to merge 5 commits into from

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented Jan 11, 2024

Discussion: #3026 (reply in thread)

I don't think we're clear on this yet, but drafting up as a proposal.

TODO:

  • Docs.
  • CHANGELOG.md.
  • Ensure we have a clear section where we outline 1.0 version changes in one place.

@tomchristie tomchristie added the 1.0 proposal Pull requests proposing 1.0 API changes label Jan 11, 2024
@tomchristie tomchristie mentioned this pull request Jan 11, 2024
@tomchristie tomchristie changed the title Unified httpx.Version parameter Add httpx.Version configuration. Jan 12, 2024
@karpetrosyan
Copy link
Member

I think we are going too far with encapsulating arguments :d

@tomchristie
Copy link
Member Author

Valid perspective yes.

@T-256
Copy link
Contributor

T-256 commented Oct 9, 2024

We should also have long term perspective since we are going to v1.0 release which then we should be semver compatible.
We may add http3 support and I think it's good to have one argument to managing client's http versions instead of three arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 proposal Pull requests proposing 1.0 API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants