Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft: fix invalid ASGI event handling #2173

Closed
wants to merge 3 commits into from
Closed

draft: fix invalid ASGI event handling #2173

wants to merge 3 commits into from

Conversation

joshua-auchincloss
Copy link

@joshua-auchincloss joshua-auchincloss commented Jun 4, 2023

Summary

Please refer to #2171 for discussion points

  • Refactor scope assertion to only check the event category (lifecycle, ws, http)

Checklist

  • [Yes] I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • [Yes] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • [Yes] I've updated the documentation accordingly.
  • [No] I've added a note on the docs/release-notes.md about my changes (changes on documentation or type annotations don't need this). - requested to maintainers to not conflict with active release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant