Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert raise ClientDisconnected on HTTP (#2276) #2276

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

ninoseki
Copy link
Contributor

Summary

Revert #2220 to fix(close) #2271.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@ninoseki ninoseki changed the title chore: revert #2220 Revert #2220 to deal with ClientDisconnected error Mar 16, 2024
@EwertonDCSilv
Copy link

Por favor, revertam essa PR, ela esta quebrando minha aplicação FastAPI !

@Kludex
Copy link
Member

Kludex commented Mar 16, 2024

Por favor, revertam essa PR, ela esta quebrando minha aplicação FastAPI !

Blz.

@ninoseki
Copy link
Contributor Author

Excuse me, I read your comments through Google Translate but I’m not sure I understand them correctly. Please let me know in English if there is anything I should change.

@Kludex
Copy link
Member

Kludex commented Mar 17, 2024

No, it's good.

@Kludex Kludex changed the title Revert #2220 to deal with ClientDisconnected error Revert raise ClientDisconnected on HTTP (#2276) Mar 19, 2024
@Kludex Kludex enabled auto-merge (squash) March 19, 2024 08:06
@Kludex Kludex merged commit 76a3812 into encode:master Mar 19, 2024
15 checks passed
@ninoseki ninoseki deleted the revert-2220 branch March 19, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants