Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.13 #2482

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Support Python 3.13 #2482

merged 2 commits into from
Oct 15, 2024

Conversation

jameshilliard
Copy link
Contributor

Summary

Run tests on 3.13 and update version support.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@zanieb
Copy link

zanieb commented Oct 8, 2024

Looks like there's a problem with uvloop

@jameshilliard jameshilliard force-pushed the python313 branch 3 times, most recently from b56887b to f0e05a7 Compare October 8, 2024 19:08
@jameshilliard
Copy link
Contributor Author

Looks like there's a problem with uvloop

Yeah, had to set a minimum uvloop version for python 3.13, httptools also had an issue with using the wrong cython version.

@zanieb zanieb requested a review from Kludex October 8, 2024 19:17
@Kludex
Copy link
Member

Kludex commented Oct 9, 2024

I'd prefer for the httptools and uvloop to make a release before proceeding here.

@jameshilliard
Copy link
Contributor Author

httptools now has a release with 3.13 support

@Kludex
Copy link
Member

Kludex commented Oct 14, 2024

Why is uvloop in beta?

pyproject.toml Outdated Show resolved Hide resolved
@Kludex Kludex changed the title Add python version 3.13 support Support Python 3.13 Oct 15, 2024
@Kludex Kludex merged commit 967a2dc into encode:master Oct 15, 2024
18 checks passed
@jameshilliard jameshilliard deleted the python313 branch October 15, 2024 17:24
raf-moreau pushed a commit to raf-moreau/uvicorn that referenced this pull request Nov 5, 2024
Co-authored-by: Marcelo Trylesinski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants