Skip to content

Commit

Permalink
Address feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
ekerfelt committed Oct 22, 2024
1 parent f82f0d0 commit 51fdd9f
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
14 changes: 7 additions & 7 deletions docs/menu.cue
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@
#DevelopmentSection,
#ObservabilitySection,
#PlatformSection,
#SelfHostingSection,
#SelfHostSection,
#ResourcesSection,
#CommunitySection,
#OtherSection,
Expand Down Expand Up @@ -746,25 +746,25 @@
}]
}

#SelfHostingSection: #SectionMenuItem & {
#SelfHostSection: #SectionMenuItem & {
kind: "section"
text: "Self Hosting"
items: [
{
kind: "basic"
text: "Build Docker Images"
path: "/how-to/self-host"
path: "/self-host/docker-build"
file: "how-to/self-host"
}, {
kind: "basic"
text: "Configure Infrastructure"
path: "/selfhosting/configure-infra"
file: "selfhosting/configure-infra"
path: "/self-host/configure-infra"
file: "self-host/configure-infra"
}, {
kind: "basic"
text: "Deploy to DigitalOcean"
path: "/selfhosting/deploy-digitalocean"
file: "selfhosting/deploy-to-digital-ocean"
path: "/self-host/deploy-digitalocean"
file: "self-host/deploy-to-digital-ocean"
}]
}

Expand Down
6 changes: 3 additions & 3 deletions docs/selfhosting/configure-infra.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ encore build docker --config path/to/infra-config.json MY-IMAGE:TAG

The configuration file should be a JSON file using the [Encore Infra Config](https://encore.dev/schemas/infra.schema.json) schema.

This includes configuring things like:
This supports configuring things like:

- How to access infrastructure resources (what provider to use, what credentials to use, etc.)
- How to call other services over the network ("service discovery"),
Expand Down Expand Up @@ -51,7 +51,7 @@ Here's an example configuration file you can use.
],
"service_discovery": {
"myservice": {
"base_url": "https://my-service:8044"
"base_url": "https://myservice:8044"
}
},
"redis": {
Expand Down Expand Up @@ -142,7 +142,7 @@ See below for examples of each type of infrastructure resource.
- `handlers`: The time allocated for processing request handlers during the shutdown.

### 3. Authentication Methods Configuration
Private endpoints will not require authentication if no authentication methods are specified. To secure private endpoints, you can configure authentication methods.
Private endpoints will not require authentication if no authentication methods are specified. This is typically fine when services are deployed on a private network such as a VPC. But sometimes you might need to connect to other services over the public internet, in which case you'll want to ensure private endpoints are only accessible to other backend services. To do that you can configure authentication methods.
Encore currently supports authentication through a shared key, which you can specify in your infrastructure configuration file.
```json
{
Expand Down
2 changes: 1 addition & 1 deletion docs/selfhosting/deploy-to-digital-ocean.md
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ DigitalOcean’s App Platform provides managed databases, allowing you to add a
export const getUser = api(
{ expose: true, method: "GET", path: "/names/:id" },
async ({id}:{id:number}): Promise<{ id: number; name: string }> => {
async ({id}: {id:number}): Promise<{ id: number; name: string }> => {
return await mydb.queryRow`SELECT * FROM users WHERE id = ${id}` as { id: number; name: string };
}
);
Expand Down

0 comments on commit 51fdd9f

Please sign in to comment.