parser/encoding: handle unions

encoredev · Jun 8, 2024 · 7169178 · 7169178
1 parent fd5f92c
commit 7169178
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 3 deletions.
diff --git a/parser/encoding/rpc.go b/parser/encoding/rpc.go
@@ -379,6 +379,25 @@ func GetConcreteType(appDecls []*schema.Decl, originalType *schema.Type, typeArg
 
 		return resolveTypeParams(&schema.Type{Typ: &schema.Type_Map{Map: mapType}}, typeArgs), nil
 
+	case *schema.Type_Union:
+		// If there are no type arguments, we've got a concrete type
+		if len(typeArgs) == 0 {
+			return originalType, nil
+		}
+
+		types := make([]*schema.Type, len(typ.Union.Types))
+		for i, t := range typ.Union.Types {
+			// Deep copy the type
+			cloned := proto.Clone(t).(*schema.Type)
+			types[i] = resolveTypeParams(cloned, typeArgs)
+		}
+
+		return &schema.Type{Typ: &schema.Type_Union{
+			Union: &schema.Union{
+				Types: types,
+			},
+		}}, nil
+
 	case *schema.Type_List:
 		// If there are no type arguments, we've got a concrete type
 		if len(typeArgs) == 0 {

diff --git a/tsparser/src/parser/types/type_resolve.rs b/tsparser/src/parser/types/type_resolve.rs
@@ -758,9 +758,9 @@ impl<'a> Ctx<'a> {
                     other => other,
                 },
 
-                ast::UnaryOp::Bang
-                | ast::UnaryOp::Tilde
-                | ast::UnaryOp::Delete => self.expr(&expr.arg),
+                ast::UnaryOp::Bang | ast::UnaryOp::Tilde | ast::UnaryOp::Delete => {
+                    self.expr(&expr.arg)
+                }
             },
             ast::Expr::Update(expr) => self.expr(&expr.arg),
             ast::Expr::Bin(expr) => {