Expose app root path to front-end #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All committers have signed the CLA. |
Test Results 2 files + 1 224 suites +66 5m 19s ⏱️ - 11m 6s Results for commit 2b5b058. ± Comparison against base commit 9166645. This pull request removes 24 and adds 203 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
simon-johansson
requested review from
DomBlack
and removed request for
eandre
This commit ports over the editor package from GitHub desktop from TypeScript into Go and gives us the ability to find editors on the user file system, list them in the UI and then open files in the UI
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
DomBlack
force-pushed
the
app-path-websocket
branch
from
cffad36
to
d1fc7da
Compare
eandre
reviewed
Sep 11, 2023
DomBlack
force-pushed
the
app-path-websocket
branch
from
57c1609
to
84b86d8
Compare
eandre
reviewed
Sep 11, 2023
DomBlack
force-pushed
the
app-path-websocket
branch
from
496f451
to
2b5b058
Compare
eandre
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that we can open the files in the users editor